Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: shortcut strings are localizable #897

Merged
merged 10 commits into from
Jun 10, 2020
Merged

Editorial: shortcut strings are localizable #897

merged 10 commits into from
Jun 10, 2020

Conversation

aarongustafson
Copy link
Collaborator

@aarongustafson aarongustafson commented Jun 8, 2020 •
edited by marcoscaceres
Loading

Closes #872

This change (choose one):

  • Makes only editorial changes (only changes informative sections, or
    changes normative sections without changing behavior)

Commit message:

Per #872, implementors are parsing lang and dir, but no one (that we know of) is implementing directionality, so I have left "Implementation commitment" blank for now.

Preview | Diff

marcoscaceres
marcoscaceres reviewed Jun 9, 2020
View reviewed changes
index.html Outdated Show resolved Hide resolved
marcoscaceres
marcoscaceres reviewed Jun 9, 2020
View reviewed changes
index.html Outdated Show resolved Hide resolved
marcoscaceres
marcoscaceres reviewed Jun 9, 2020
View reviewed changes
index.html Outdated Show resolved Hide resolved
marcoscaceres
marcoscaceres reviewed Jun 9, 2020
View reviewed changes
index.html Outdated Show resolved Hide resolved
marcoscaceres
marcoscaceres requested changes Jun 9, 2020
View reviewed changes
Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits...

aarongustafson and others added 5 commits June 9, 2020 08:14
@aarongustafson @marcoscaceres
Updates syntax
72e9da4 
Co-authored-by: Marcos Cáceres <marcos@marcosc.com>
@aarongustafson @marcoscaceres
Updates syntax
c8d6220 
Co-authored-by: Marcos Cáceres <marcos@marcosc.com>
@aarongustafson @marcoscaceres
Updates syntax
4606295 
Co-authored-by: Marcos Cáceres <marcos@marcosc.com>
@aarongustafson @marcoscaceres
Text tweak
ddc07bf 
Co-authored-by: Marcos Cáceres <marcos@marcosc.com>
@aarongustafson
Merge branch 'gh-pages' into dir-shortcuts
c53b45e
@aarongustafson
Copy link
Collaborator Author

@marcoscaceres Accepted & merged

@aarongustafson
Copy link
Collaborator Author

@marcoscaceres Those validation error messages are not me, right? What do we need to fix?

@marcoscaceres marcoscaceres changed the title Noting that shortcut strings are localizable Editorial: shortcut strings are localizable Jun 10, 2020
@marcoscaceres
Copy link
Member

@marcoscaceres Those validation error messages are not me, right? What do we need to fix?

Nope, they are #884 ... working on it behind the scenes.

@marcoscaceres marcoscaceres merged commit 1a37c12 into w3c:gh-pages Jun 10, 2020
marcoscaceres pushed a commit that referenced this pull request Jun 10, 2020
@aarongustafson @marcoscaceres
editorial: shortcut strings are localizable (#897)
2f0b0f7
@xfq xfq mentioned this pull request Jun 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

@kenchris kenchris kenchris approved these changes

@mgiuca mgiuca Awaiting requested review from mgiuca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should dir and lang apply to name/description of app shortcuts?
3 participants
@aarongustafson @marcoscaceres @kenchris